Added payload to the request build. This fixes #30. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice this leaves the queryString untouched in a way to allow even for |
naroga
changed the title
naroga
changed the title
|
This fixes #30. |
|
This will only work for non-streamed requests. See this comment for buffering and reading the entire body for non-streamed requests. |
|
Obsolete because of b36fb25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of right now, if one passes a payload on a request to react/http, such as the following:
The payload is unreachable within the server. It won't be parsed as a querystring on
RequestHeaderParser::parseRequestand will thus be discarded.This can't happen, and I believe this PR fixes the issue.
It adds a new parameter to the Request constructor ($payload), at the end, with a default value (
null), as a way to not break backwards compatibility with classes that may omit this parameter. It also adds agetPayload()method to the request.